test: use SpecVersion enum in tests in preparation for OAS 3.2 - #5254
Open
Mattias-Sehlstedt wants to merge 1 commit into
Open
test: use SpecVersion enum in tests in preparation for OAS 3.2#5254Mattias-Sehlstedt wants to merge 1 commit into
Mattias-Sehlstedt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
The swagger ecosystem has started moving towards supporting OAS 3.2. As part of enabling that in swagger-core, it would be helpful to move away from the previous binary
openapi31boolean configuration, and instead attempting to move to using theSpecVersionenum (which can then be extended with V32 and any version that comes after that).I have for example introduced support for OAS 3.2
tagson a branch, but it is more difficulty to review and reason about due to the changes to the version handling necessary. Thus I would find it beneficial if we could remove the usage of the boolean flag before any 3.2 functionality was introduced. The same applies to another recent PR tied to 3.2QUERYoperation functionality.My general approach is to implement the functionality first, and analyze what workflows are cumbersome, and then extract the fixes for the cumbersome parts as a separate PR without the new functionality.
Relates to #5181
Type of Change
Checklist
Screenshots / Additional Context